Re: [PATCH] via82cxxx IDE: Remove /proc/via entry

[Grzegorz Kulewski]

On Thu, 29 Sep 2005, Bartlomiej Zolnierkiewicz wrote:

> On 9/29/05, Grzegorz Kulewski <kangur@xxxxxxxxxx> wrote:
> > On Wed, 28 Sep 2005, Daniel Drake wrote:
> >
> > > This entry adds needless complication to the driver as it requires the use of
> > > global variables to be passed into via_get_info(), making things quite ugly
> > > when we try and make this driver support multiple controllers simultaneously.
> > >
> > > This patch removes /proc/via for simplicity.
> >
> > Is similar data available from sysfs?
> >
> > As a user of this controller, I think that if it is not then this patch
> > should be changed to export it or should be dropped. The data from that
> > file is really helpfull in debugging problems (for example related to bad
> > cables or breaking disks/cdroms).
>
> Could you please give some details (which data is useful)?

Sorry for delay - I was very busy during past week.

Well, I guess that thanks to this file I am able to know that the drive is 
connected to via chipset and not to some pseudo raid controller (it is 
important if I am working remotely), if it has 80w cables attached, what 
is attached where, what are controller parameters, dma rate and timings 
(if they are strange I can suspect that something bad is happening with 
the drive / controler).

I am not saying that these data are not available elsewhere (but some are 
not for sure). But they are presented nicely in one standard place and 
this is in my opinion good.

But I understand the desire to remove all files that can be removed from 
/proc. So I am just suggesting to move some of the data (like type of 
cable detected for example) to sysfs if they are not already there.


Thanks,

Grzegorz Kulewski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/