Re: [RFC] gfp flags annotations - part 6 (simple parts of fs/*)
From: Tom Zanussi
Date: Sun Oct 09 2005 - 10:45:06 EST
Al Viro writes:
> A bug had been caught in relayfs code -
> mem = vmap(buf->page_array, n_pages, GFP_KERNEL, PAGE_KERNEL);
> in fs/relayfs/buffers.c is bogus (the third argument of vmap() is unrelated
> to gfp flags). s/GFP_KERNEL/VM_MAP/, presumably? Author Cc'd, code in
> question left alone for now.
Yes, looks like a stupid typo that luckily wasn't affecting the
outcome because the GFP_KERNEL value happens to not cause any false
test outcomes in the vmap code. I'll submit a patch momentarily.
Thanks for catching this.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/