Re: [PATCH] UML TT-mode-only compile fix.

From: Blaisorblade
Date: Sun Oct 09 2005 - 14:27:11 EST

On Sunday 09 October 2005 07:06, Junichi Uekawa wrote:
> Hi,
> In today's linus's git tree, uml doesn't compile when it's configured for
> only TT-mode.

> This regression caused by:
> 8923648c125421b0fcb240cde607e2748d099ab8
> [PATCH] uml: clear SKAS0/3 flags when running in TT mode
> Signed-off-by: Junichi Uekawa <dancer@xxxxxxxxxx>
Thanks for the report and the patch, however I want to fix things a bit
differently... the thing _should_ compile anyway.

The macro is declared anyway and the var should exist anyway.
The problem is just that they aren't declared, I think. Will fix.

> diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
> --- a/arch/um/kernel/um_arch.c
> +++ b/arch/um/kernel/um_arch.c
> @@ -334,8 +334,10 @@ int linux_main(int argc, char **argv)
> os_early_checks();
> if (force_tt)
> clear_can_do_skas();
> +#endif
> mode_tt = force_tt ? 1 : !can_do_skas();
> #ifndef CONFIG_MODE_TT
> if (mode_tt) {

Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)

Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at