Re: bug in handling of highspeed usb HID devices

[Parag Warudkar]

> 
> Yes, but in this case we have to check all callers of usb_fill_int_urb
> to do the recalculation. E.g. in input/usbmouse.c
> endpoint->bInterval is used directly as parameter to usb_fill_int_urb.

Absolutely correct - There are 41 callers per LXR in 2.6.11 - may be even more in the current kernel.

> 
> To avoid breaking things (my suggested patch has no impact on any other
> usb driver) and to solve the problem shortly, I suggest to
> use my patch and do some kind of refactoring later (You are right,
> for a clean interface the interval parameter should have the same
> meaning independend of the speed).
> 
> 

Agreed. Looking at some of the callers, it will take some time and refactoring to fix all of them. For now, it makes sense to put your patch in if no one has an objection.

Thanks

Parag



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/