Re: [discuss] [Patch 1/2] x86, x86_64: Intel HT, Multi core detection fixes

[Andi Kleen]

On Thursday 13 October 2005 00:19, Siddha, Suresh B wrote:

> x86_num_cores (cpuid returned value) is required while right shifting the 
> apicid to get the core-id and the package-id. booted_cores will indicate 
> how many cores actually cameup. x86_num_cores can differ from "booted cores" 
> in these scenarios

The original idea was to round it up to the next power of two 
before shifting. But I can see that it will break when the number
of online cores differs from the max number by more than a single power 
of two (e.g. quadcore with only a single CPU booted) 

Ok, if you rename the variable to make it clear

x86_num_cores -> x86_max_cores


-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/