Re: [PATCH 09/14] Big kfree NULL check cleanup - misc remainingdrivers

[Roland Dreier]

    Mike> I'm not sure I agree that these are pointless
    Mike> checks. They're not in the main code path so nothing is lost
    Mike> by checking first. What if the pointer is NULL????

Read the source to kfree().  The first thing it does is check if the
pointer it is passed is NULL, so the only thing that checking in the
caller does is save a function call.  However I agree with Jesper that
saving .text and cutting down on source code size far outweighs the
cost of these extra function calls.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/