Re: [PATCH 09/14] Big kfree NULL check cleanup - misc remaining drivers
From: Pierre Ossman
Date: Thu Oct 13 2005 - 23:57:38 EST
Jesper Juhl wrote:
> This is the remaining misc drivers/ part of the big kfree cleanup patch.
> Remove pointless checks for NULL prior to calling kfree() in misc files in drivers/.
> Sorry about the long Cc: list, but I wanted to make sure I included everyone
> who's code I've changed with this patch.
> Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
> --- linux-2.6.14-rc4-orig/drivers/mmc/wbsd.c 2005-10-11 22:41:10.000000000 +0200
> +++ linux-2.6.14-rc4/drivers/mmc/wbsd.c 2005-10-12 15:43:04.000000000 +0200
> @@ -1595,8 +1595,7 @@ static void __devexit wbsd_release_dma(s
> if (host->dma_addr)
> dma_unmap_single(host->mmc->dev, host->dma_addr, WBSD_DMA_SIZE,
> - if (host->dma_buffer)
> - kfree(host->dma_buffer);
> + kfree(host->dma_buffer);
> if (host->dma >= 0)
Looks good. Thanks.
Acked-by: Pierre Ossman <drzeus@xxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/