Re: amd_detect_cmp messing up initial apic id and apic id

From: Andi Kleen
Date: Fri Oct 14 2005 - 04:35:20 EST


On Friday 14 October 2005 09:09, yhlu wrote:
> andi,
>
> in arch/x86_64/setup.c amd_detect_cmp, the code already using initial apic
> to get node id, why adding some extra code double check the node id?

Because it is not necessarily matching.

>
> Also
> apicid = phys_proc_id[cpu]; <----- initial apic id
>
> and then apicid_to_node[apicid]....
>
> that is wrong if the cpu apic id is lifted.

Can you describe exactly what you think is wrong?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/