Re: [RFC][PATCH] rcu in drivers/net/hamradio

From: Herbert Xu
Date: Fri Oct 14 2005 - 08:37:45 EST

Suzanne Wood <suzannew@xxxxxxxxxx> wrote:
> (1) bpq_new_device() calls list_add_rcu() labeled as
> "list protected by RTNL." The comment may need to go
> since the only apparent rtnl_lock()/unlock() pair encloses
> the call to bpq_free_device() in bpq_cleanup_driver()
> called upon module_exit().

The RTNL comment is correct actually.

bpq_new_device can only be called from bpq_device_event which
is called from a netdev event handler. All netdev event handlers
must be called uner the RTNL.

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at