Re: [PATCH 08/14] Big kfree NULL check cleanup - drivers/media

From: Andreas Oberritter
Date: Fri Oct 14 2005 - 16:57:55 EST


On Thu, 2005-10-13 at 21:28 +0200, Jesper Juhl wrote:
> This is the drivers/media/ part of the big kfree cleanup patch.
>
> Remove pointless checks for NULL prior to calling kfree() in drivers/media/.
>
>
> Sorry about the long Cc: list, but I wanted to make sure I included everyone
> who's code I've changed with this patch.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>
> ---
>

[...]

> --- linux-2.6.14-rc4-orig/drivers/media/dvb/frontends/mt312.c 2005-08-29 01:41:01.000000000 +0200
> +++ linux-2.6.14-rc4/drivers/media/dvb/frontends/mt312.c 2005-10-13 10:28:50.000000000 +0200
> @@ -675,8 +675,7 @@ struct dvb_frontend* mt312_attach(const
> return &state->frontend;
>
> error:
> - if (state)
> - kfree(state);
> + kfree(state);
> return NULL;
> }
>

Acked-by: Andreas Oberritter <obi@xxxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/