Re: Possible memory ordering bug in page reclaim?

From: Herbert Xu
Date: Sat Oct 15 2005 - 07:10:48 EST

Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
> Well yes, that's on the store side (1, above). However can't a CPU
> still speculatively (eg. guess the branch) load the page->flags
> cacheline which might be satisfied from memory before the page->count
> cacheline loads? Ie. you can still have the correct write ordering
> but have incorrect read ordering?
> Because neither PageDirty nor page_count is a barrier, and there is
> no read barrier between them.

Yes you're right. A read barrier is required here.

I think Ben was actually agreeing with you. He's just questioning
whether the corresponding write barrier existed on CPU 1 (the answer
to which is affirmative).

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at