Re: [patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?

From: Andi Kleen
Date: Mon Oct 17 2005 - 11:41:44 EST


On Monday 17 October 2005 18:33, Tim Schmielau wrote:

>
> [Looks like you are on x86_64, as i386 compiles fine]
>
> Actually, <asm-x86_64/atomic.h> seems to need <asm/types.h> for the
> declaration of u32.
> The patch below makes NTFS compile on x86_64 for me. Andi?
>
> Tim

-mm specific problem caused by the bluesmoke merges.

IMHO the right fix is to put that atomic scrub thingy into another include
file. It seems to cause major additional include dependencies and
is only used in a single file right now.

-Andi

>
> --- linux-2.6.14-rc4-mm1/include/asm-x86_64/atomic.h 2005-10-17
> 17:48:12.000000000 +0200 +++
> linux-2.6.14-rc4-mm1-build/include/asm-x86_64/atomic.h 2005-10-17
> 18:20:19.000000000 +0200 @@ -2,6 +2,7 @@
> #define __ARCH_X86_64_ATOMIC__
>
> #include <linux/config.h>
> +#include <asm/types.h>
>
> /* atomic_t should be 32 bit signed type */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/