Re: [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option

From: Marcelo Tosatti
Date: Tue Oct 18 2005 - 08:02:25 EST


On Fri, Oct 14, 2005 at 10:19:44AM +0100, Nick Warne wrote:
>
> >> #ifdef CONFIG_VT
> >> +#ifndef CONFIG_DUMMY_KEYB
>
> > Please could you change this to #if defined(CONFIG_VT) &&
> > !defined(CONFIG_DUMMY_KEYB) ?
>
> > Marcelo, I'd like this one to be merged, as it is useful to many of us,
> > and is already fixed in 2.6 (where you're not forced to have a
> > keyboard). It's not intrusive and at most a build fix. Would you please
> > accept Nick's patch after the little clean-up above ?
>
>
> OK, the adjusted patch attached. I did look at the ifdefs in that file
> for a few minutes; but I see now I should have done it like this in the
> first place.

Looks fine - Willy can you keep it in your tree and add it later on to the
2.4.33-pre tree?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/