Re: 2.6.14-rc5-rt1

[Ingo Molnar]

* Felix Oxley <lkml@xxxxxxxxx> wrote:

> A second build error with make allyesconfig:

ah, indeed.

> Seems to be a probelm with definition ktimer_trace :
> 
> Signed-off-by: Felix Oxley <lkml@xxxxxxxxx>
> ---
> --- include/linux/ktimer.h		2005-10-21 00:20:03.000000000 +0100
> +++ include/linux/ktimer.h	 	2005-10-21 10:55:44.000000000 +0100
> @@ -141,7 +141,7 @@ extern int ktimer_interrupt(void);
>  #define KTIME_REALTIME_RES             CONFIG_HIGH_RES_RESOLUTION
>  #define KTIME_MONOTONIC_RES            CONFIG_HIGH_RES_RESOLUTION
> 
> -#define ktimer_trace(a,b)              trace_special((a).tv.sec,(a).tv.nsec,b)
> +#define ktimer_trace(a,b)              trace_special((a).tv_sec,(a).tv_nsec,b)

yeah. Btw., your fix is still not complete (it wont work with the scalar 
representation of ktime_t, on 64-bit platforms) - the full solution 
should be the patch below.

	Ingo

Index: linux/include/linux/ktimer.h
===================================================================
--- linux.orig/include/linux/ktimer.h
+++ linux/include/linux/ktimer.h
@@ -141,7 +141,7 @@ extern int ktimer_interrupt(void);
 #define KTIME_REALTIME_RES		CONFIG_HIGH_RES_RESOLUTION
 #define KTIME_MONOTONIC_RES		CONFIG_HIGH_RES_RESOLUTION
 
-#define ktimer_trace(a,b)		trace_special((a).tv.sec,(a).tv.nsec,b)
+#define ktimer_trace(a,b)		trace_special(ktime_get_high(a),ktime_get_low(a),b)
 
 #else
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/