Re: [PATCH 1/4] Swap migration V3: LRU operations

[Nikita Danilov]

Dave Hansen writes:

[...]

 > 
 > It makes much more sense to have something like:
 > 
 >         if (ret == ISOLATION_IMPOSSIBLE) {
 >         	 list_del(&page->lru);
 >          	 list_add(&page->lru, src);
 >         }
 > 
 > than
 > 
 > +               if (rc == -1) {  /* Not possible to isolate */
 > +                       list_del(&page->lru);
 > +                       list_add(&page->lru, src);
 > +                } if 

And
         if (ret == ISOLATION_IMPOSSIBLE)
          	 list_move(&page->lru, src);

is even better.

Nikita.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/