Re: select() for delay.

[Christopher Friesen]

Arnd Bergmann wrote:
> On Maandag 24 Oktober 2005 12:55, madhu.subbaiah@xxxxxxxxx wrote:

> > This patch improves the sys_select() execution when used for delay. 

> Please describe what aspect of the syscall is improved. Is this only
> speeding up the execution for the delay case while slowing down
> the normal case, or do the actual semantics improve?

It appears to simply speed up the delay case.

One thing that I noticed though--the patch had the following line:

if ((n == 0) && (inp == NULL) && (outp == NULL) && (exp == NULL)) {


Would it be enought to just do the following?

if (n == 0) {

Given that if any of the fd_set pointers are non-empty, "n" ought to be 
non-zero, would this be a sufficient check?

Chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/