Re: [PATCH] Eagle and ADI 930 usb adsl modem driver

[Andrew Morton]

matthieu castet <castet.matthieu@xxxxxxx> wrote:
>
> Hi Duncan,
> 
> Duncan Sands wrote:
> > Hi Andrew,
> > 
> > 
> > this code looks like a 'orrible hack to work around a common problem
> > with USB modem's of this type: if the modem is plugged in while the
> > system boots, the driver may look for firmware before the filesystem
> 
> No, it wasn't the problem, even when loading with insmod/modprobe the 
> timeout occurs on some configurations. For example on 
> http://atm.eagle-usb.org/wakka.php?wiki=TestUEagleAtmBaud123, you could 
> see the 'firmware ueagle-atm/eagleIII.fw is not available' error.
> 
> It is only happen for pre-firmware modem (uea_load_firmware) ie where we 
> just do a request_firmware in the probe without any initialisation before.
> So the problem seems to appear when we do a request_firmware too early 
> in the usb_probe.
> 

Can you please work out exactly what's happening and come up with a more
solid solution than msleep(1)?

Because other drivers may hit this problem (whatever it is) and fixes in
core kernel might be needed.  If we just work around stuff, core kernel
remains unfixed...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/