Re: [PATCH] Eagle and ADI 930 usb adsl modem driver

[Andrew Morton]

matthieu castet <castet.matthieu@xxxxxxx> wrote:
>
> >>+
>  >>+	*cmvs = (struct uea_cmvs *)(data + 1);
>  > 
>  > 
>  > That's a bit rude - asking the compiler to perform a structure copy from an
>  > odd address.  memcpy() would be saner.
>  > 
>  Could you elaborate a bit more ?
>  I don't see where there is a copy.
>  *cmvs is a pointer to the structure, not the structure. And when we 
>  parse the structure, we use get_unaligned functions.
> 
> 

Ah, I misread the code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/