Re: fs/fat - fix sparse warning

From: OGAWA Hirofumi
Date: Wed Nov 02 2005 - 13:40:33 EST


Adrian Bunk <bunk@xxxxxxxxx> writes:

> It sometimes happens that the signature of a function changes and it is
> forgotten to update all prototypes.
>
> If the prototype is in a header file, gcc tells about the mistake.
>
> If the prototype is in the C file gcc can't help us and it might take
> some time until someone tracks the source of the nasty runtime problems
> this might cause.
>
> It's your choice as subsystem maintainer which header file the
> prototypes should go into - it is only important that both the file with
> the actual function and all users of this function #include this header.

Sounds reasonable, although that's unlikely, because those are
init/exit functions. OK, I'll do this in header cleanup as soon as possible.

Thanks.
--
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/