Re: post-2.6.14 USB change breaks sparc64 boot

From: Greg KH
Date: Thu Nov 03 2005 - 18:27:19 EST


On Thu, Nov 03, 2005 at 09:33:28AM -0800, David S. Miller wrote:
>
> This change:
>
> diff-tree 478a3bab8c87a9ba4a4ba338314e32bb0c378e62 (from 46f116eab81b21c6ae8c4f169498c632b1f94bf1)
> Author: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Date: Wed Oct 19 12:52:02 2005 -0400
>
> [PATCH] USB: Always do usb-handoff
>
> This revised patch (as586b) makes usb-handoff permanently true and no
> longer a kernel boot parameter. It also removes the piix3_usb quirk code;
> that was nothing more than an early version of the USB handoff code
> (written at a time when Intel's PIIX3 was about the only motherboard with
> USB support). And it adds identifiers for the three PCI USB controller
> classes to pci_ids.h.
>
> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
> breaks sparc64 bootup badly on machines with USB host controllers.

Does Linus's current tree fix this? I ask, because I thought that:

Author: Linus Torvalds <torvalds@xxxxxxxxxxx> 2005-10-31 21:12:40
Committer: Linus Torvalds <torvalds@xxxxxxxxxxx> 2005-10-31 21:12:40
Parent: 1e4c85f97fe26fbd70da12148b3992c0e00361fd (Revert "i386: move apic init in init_IRQs")
Child: df70b17f88a4d1d8545d3569a1f6d28c6004f9e4 (Merge git://git.kernel.org/pub/scm/linux/kernel/git/aia21/ntfs-2.6)

Don't touch USB controller IO registers when they are disabled

The USB "handoff" code is an early PCI quirk to make sure we own the USB
controller (as opposed to the BIOS/SMM). But if the controller isn't
even enabled yet, don't try to access it.

Acked-by: Paul Mackerras <paulus@xxxxxxxxx> (who had an alternate patch)
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>


Should have fixed this. If not, please let me know.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/