Re: [PATCH 04/37] dvb: Add ATSC support for DViCO FusionHDTV5 Lite

[Michael Krufky]

Andrew Morton wrote:

> Michael Krufky <mkrufky@xxxxxxx> wrote:
>  
>
> > +static int tdvs_tua6034_pll_set(struct dvb_frontend* fe, struct dvb_frontend_parameters* params)
> > +{
> > +	struct dvb_bt8xx_card *card = (struct dvb_bt8xx_card *) fe->dvb->priv;
> >    
>
> The cast of a void* is unneeded.  It's actually undesirable: if someone
> were to convert the thing-being-casted to some other scalar type, the cast
> would prevent the desired compiler warning.
Alexey Dobriyan wrote:

> Please, also
>
> 	struct dvb_frontend *fe, struct dvb_frontend_parameters *params)
> 			   ^				       ^
Both of these problems are all over dvb-kernel... We'll fix it up.

Thanks,

Michael Krufky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/