Re: ALPHA: missing reference to barrier()

From: Daniel Drake
Date: Fri Nov 04 2005 - 08:32:10 EST


alpha @ steudten Engineering wrote:
ONLY for linux ALPHA:

Please add patch to the source tree..

Hello

In the kernel source 2.6.14 from kernel.org build with the given config1, the
symbol barrier() is missing in linux/include/asm-alpha/atomic.h with gcc 4.0.1 from
FC4.

This is defined in linux/compiler.h or asm/compiler.h.

An alternative patch has already been merged into Linus' git tree. It should fix your problem.

Daniel From: Ivan Kokshaysky <ink@xxxxxxxxxxxxxxxxxxxx>
Date: Sun, 30 Oct 2005 01:15:43 +0000 (-0700)
Subject: [PATCH] fix alpha breakage
X-Git-Url: http://www.kernel.org/git/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=63f324cf0792ed69089b79d6921ba3aaea97af50

[PATCH] fix alpha breakage

barrier.h uses barrier() in non-SMP case. And doesn't include compiler.h.

Cc: Al Viro <viro@xxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>
---

--- a/include/asm-alpha/barrier.h
+++ b/include/asm-alpha/barrier.h
@@ -1,6 +1,8 @@
#ifndef __BARRIER_H
#define __BARRIER_H

+#include <asm/compiler.h>
+
#define mb() \
__asm__ __volatile__("mb": : :"memory")