Re: [PATCH 1/2] slob: introduce mm/util.c for shared functions

[Paulo Marques]

Pekka Enberg wrote:
> On 11/4/05, Matt Mackall <mpm@xxxxxxxxxxx> wrote:
>
> > Well, yes. But I decided not to do that now because I ended up wanting
> > to create mm/util.c anyway for kzalloc. I suspect we'll see other
> > helper functions like kzalloc and kstrdup down the road.
>
> I prefer this as well. kstrdup() is _not_ a string operation but a
> special purpose memory allocator just like kzalloc() and kcalloc().

It is even worse than just personal preference.

Having kstrdup in lib/string was actually tried first, but there are 
archs that use lib/string for their boot code.

This boot code has no kmalloc available, so the dependency of kstrdup on 
kmalloc breaks the build for them if kstrdup is moved to lib/string.

--
Paulo Marques - www.grupopie.com

The rule is perfect: in all matters of opinion our
adversaries are insane.
Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/