Re: [RFC,PATCH] libfs dcache_readdir() and dcache_dir_lseek() bugfix

[Miklos Szeredi]

> > > > > 
> > > > > Well, glibc is that stupid and triggers the bug.
> > > > 
> > > > Seems to me, the simple solution is to upgrade your glibc.
> > > > 
> > > 
> > > This is SLES8. You don't want to update the glibc.
> > 
> > OK, but then it's basically a SLES8 kernel issue, not a mainline
> > kernel issue.
> > 
> > Probably very few people are using brand new kernels with glibc from
> > the last millennium ;)
> > 
> 
> Hmm, so I should only send patches for bugs that are often triggered
> upstream? Just start using seekdir() and modify the directory contents on an
> upstream tmpfs. You'll see that this isn't working well.
> 
> This is a bug and it should get fixed. I hope that it doesn't depend on how
> many people using what library :)

Ah, but it's a bug in the _system_ and glibc is part of the system
too, not just the kernel.

Upgrading glibc solves the problem, so why work around it in kernel
too?

Your patch is not a solution, since readdir will remain nonconforming.
It is basically a workaround for a bug in glibc.  It makes readdir
nonconforming in a different way, but the end result in not
necessarily better.

If you manage to make dcache_readdir conform to SUS without overly
bloating the implementation, that's fine.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/