Re: [PATCH]: Clean up of __alloc_pages

From: Nick Piggin
Date: Fri Nov 04 2005 - 18:58:09 EST


Rohit Seth wrote:


Nick, sorry for not responding earlier.


That's OK.

I agree that it is slight change in behavior from original. I doubt
though it will impact any one in any negative way (may be for some
higher order allocations if at all). On a little positive side, less
frequent calls to kswapd for some cases and clear up the code a little
bit.


I really don't want a change of behaviour going in with this,
especially not one which I would want to revert anyway. But
don't get hung up with it - when you post your latest patch
I will make a patch for the changes I would like to see for it
and synch things up.

But I really don't want to get stuck here. The pcp traversal and
flushing is where I want to go next.


Sure, hope it goes well!

Nick

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/