Re: [patch 2/5] atomic: cmpxchg

From: Russell King
Date: Sat Nov 05 2005 - 04:13:19 EST


On Sat, Nov 05, 2005 at 08:10:53PM +1100, Nick Piggin wrote:
> While you're here, does the assembly code for the SMP version look
> OK? You basically provided me with it but I don't think you saw its
> final form.

Looks fine. The only comment is changing the "r" (old) to be
"Ir" (old). The "I" tells the compiler that it may also use a
constant for that argument, which may allow it to optimise the
code a bit better.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/