Re: 2.6.14: CR4 not needed to be inspected on the 486 anymore?

From: Andi Kleen
Date: Sat Nov 05 2005 - 12:40:12 EST


Zachary Amsden <zach@xxxxxxxxxx> writes:
>
> He won't like me too much. I'll write up a proper patch for this, a la
> mode de rdmsr_safe / wrmsr_safe. At least it's not a bug, just missing
> information.

I don't think it's a good idea. Relying on nested faults in oops
is a bit unsafe because it could lead to recursive faults in the worst case.
Yes it does it already with __get_user, but that
is only last resort. You would make it default on these systems.

Better keep the if

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/