Re: [PATCH] Set the vga cursor even when hidden

From: Antonino A. Daplas
Date: Sat Nov 05 2005 - 21:12:05 EST


Samuel Thibault wrote:
> Hi,
>
> Antonino A. Daplas, le Sun 06 Nov 2005 08:37:27 +0800, a écrit :
>> Why not use this method (scanline_end < scanline_start) for VGA, and
>> the default method (moving the cursor out of the screen) for the rest?
>
> Well, visually impaired people might want to use other cards as well.

See Linus's comments about that :-)

>
>> Or why not just set bit 5 of the cursor start register (port 0x0a) to disable
>> the cursor, and clear to enable? I believe this will also work for the
>> other types.
>
> If this works, it would be fine.

No, forget about that. It sounds simple, but when the cursor is moved, the
cursor is unavoidably reenabled again (in vgacon_set_cursor_size). So this method
will require more work for what's it worth. Your patch is much simpler and uses
known working code.

Tony


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/