Re: [2.6 patch] rename hostap.c to hostap_main.c

From: Jouni Malinen
Date: Sat Nov 05 2005 - 23:21:15 EST


On Sun, Nov 06, 2005 at 01:53:43AM +0100, Adrian Bunk wrote:
> I wanted to remove the #include "hostap_ioctl.c" from hostap.c and build
> hostap_ioctl.c separately, but this doesn't work since hostap.c has the
> same name as the module.

Is this patch changing anything in hostap.c or is it just a rename of
the file? Patch file is not exactly ideal for this kind of changes and I
hope git has a better way of storing this kind of rename.

I would rather not rename the file, but if this is the only way of
getting the module built in pieces, I'm okay with the change (assuming
nothing else changed in hostap.c in this changeset).


> +++ linux-2.6.14-rc5-mm1-full/drivers/net/wireless/hostap/Makefile 2005-11-06 00:14:57.000000000 +0100
> @@ -1,5 +1,7 @@
> -obj-$(CONFIG_HOSTAP_CS) += hostap_cs.o
> -obj-$(CONFIG_HOSTAP_PLX) += hostap_plx.o
> -obj-$(CONFIG_HOSTAP_PCI) += hostap_pci.o
> +obj-$(CONFIG_HOSTAP) += hostap.o
> +
> +obj-$(CONFIG_HOSTAP_CS) += hostap_cs.o
> +obj-$(CONFIG_HOSTAP_PLX) += hostap_plx.o
> +obj-$(CONFIG_HOSTAP_PCI) += hostap_pci.o

Why were the hostap_{cs,plx,pci} lines changed? I prefer the original
version of those lines (i.e., no extra padding).

--
Jouni Malinen PGP id EFC895FA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/