Re: [PATCH 12/18] shared mount handling: bind and rbind

From: Miklos Szeredi
Date: Tue Nov 08 2005 - 09:11:56 EST


> static void attach_mnt(struct vfsmount *mnt, struct nameidata *nd)
> {
> - mnt->mnt_parent = mntget(nd->mnt);
> - mnt->mnt_mountpoint = dget(nd->dentry);
> - list_add(&mnt->mnt_hash, mount_hashtable + hash(nd->mnt, nd->dentry));
> + mnt_set_mountpoint(nd->mnt, nd->dentry, mnt);
> + list_add_tail(&mnt->mnt_hash, mount_hashtable +
> + hash(nd->mnt, nd->dentry));

Ram,

IIRC the list_add -> list_add_tail change has been voted down. Or do
you have new reasons why it's needed?

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/