Re: [KJ] [PATCH 6/8] Cleanup slabinfo_write()

From: Matthew Dobson
Date: Tue Nov 08 2005 - 14:09:08 EST


Christoph Lameter wrote:
> On Tue, 8 Nov 2005, Alexey Dobriyan wrote:
>
>
>>On Mon, Nov 07, 2005 at 04:57:27PM -0800, Matthew Dobson wrote:
>>
>>>* Set 'res' at declaration instead of later in the function.
>>
>>I hate to initialize a varible two miles away from the place where it's
>>used.
>
>
>
>
>>>- int limit, batchcount, shared, res;
>>>+ int limit, batchcount, shared, res = -EINVAL;
>
>
> Looks more confusing than before.

Fair enough. I'll drop that bit.

-Matt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/