Re: [-mm patch] USB_LIBUSUAL shouldn't be user-visible

[Greg KH]

On Tue, Nov 08, 2005 at 01:47:16AM +0100, Adrian Bunk wrote:
> On Mon, Nov 07, 2005 at 02:28:40PM -0800, Greg KH wrote:
> > On Mon, Nov 07, 2005 at 05:26:10PM -0500, Alan Stern wrote:
> > > On Mon, 7 Nov 2005, Greg KH wrote:
> > > 
> > > > On Mon, Nov 07, 2005 at 10:10:28PM +0100, Adrian Bunk wrote:
> > > > > On Sun, Nov 06, 2005 at 06:24:47PM -0800, Andrew Morton wrote:
> > > > > >...
> > > > > > Changes since 2.6.14-rc5-mm1:
> > > > > >...
> > > > > > +gregkh-usb-usb-libusual.patch
> > > > > > 
> > > > > >  USB tree updates
> > > > > >...
> > > > > 
> > > > > IMHO, CONFIG_USB_LIBUSUAL shouldn't be a user-visible variable but 
> > > > > should be automatically enabled when it makes sense.
> > > > 
> > > > The trick is, when does it "make sense"?
> > > > 
> > > > Anyone have any ideas?
> > > 
> > > The simplest answer is to configure it whenever usb-storage and ub are 
> > > both configured.  libusual has no purpose otherwise.
> > 
> > Ok, care to write up the Kconfig for that?
> 
> 
> Patch below.
> 
> 
> The more I think about it, the more I think that this might be a bit too 
> complicated.
> 
> What about letting the two drivers always use libusual?

Pete?  What do you think about this patch?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/