Re: [PATCH]: Cleanup of __alloc_pages

From: Paul Jackson
Date: Sun Nov 13 2005 - 00:33:34 EST


An even stranger line:

fs/xfs/linux-2.6/xfs_buf.c has:
aentry = kmalloc(sizeof(a_list_t), GFP_ATOMIC & ~__GFP_HIGH);

Given the gfp.h line:
#define GFP_ATOMIC (__GFP_VALID | __GFP_HIGH)

that xfs_buf line makes no sense. There is almost no chance
that the author of that xfs_buf.c line was aware they were
spelling the empty gfp flag __GFP_VALID.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/