Re: [RFC][PATCH 5/6] PCI PM: kzalloc() cleanup

From: Greg KH
Date: Wed Nov 16 2005 - 01:47:19 EST


On Tue, Nov 15, 2005 at 10:31:31PM -0500, Adam Belay wrote:
> Use kzalloc() instead of kmalloc() and memset().
>
>
> --- a/drivers/pci/pm.c 2005-11-08 17:10:37.000000000 -0500
> +++ b/drivers/pci/pm.c 2005-11-08 17:11:33.000000000 -0500
> @@ -300,12 +300,10 @@
> return -EIO;
> }
>
> - dev->pm = pm_data = kmalloc(sizeof(struct pci_dev_pm), GFP_KERNEL);
> + dev->pm = pm_data = kzalloc(sizeof(struct pci_dev_pm), GFP_KERNEL);
> if (!pm_data)
> return -ENOMEM;
>
> - memset(pm_data, 0, sizeof(struct pci_dev_pm));
> -

You can merge this back with your other patch :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/