Re: floppy regression from "[PATCH] fix floppy.c to store correct ..."

From: Bill Davidsen
Date: Mon Nov 28 2005 - 14:13:55 EST


Andrew Morton wrote:
Jon Masters <jonmasters@xxxxxxxxx> wrote:

On 11/22/05, Andrew Morton <akpm@xxxxxxxx> wrote:


That still does the wrong thing. Put in a write-protected floppy, try to
write to it and it says -EROFS. Then pop the WP switch and try to
write to it again and it wrongly claims EPERM. A second attempt to
write will succeed.

The problem is that we need to wait until the floppy driver next
checks the read status on the drive. I think to get it completely
right will take moving bits of the floppy driver around, unless I'm
being stupid. I'm planning to do that too though.



In the meanwhile I think we should revert back to the 2.6.14 version of
floppy.c - the present problem is probably worse than the one which it
kinda-fixes.

I think that's best, because there are few people (relatively) using floppy, and those who are probably are used to old behaviour.
--
-bill davidsen (davidsen@xxxxxxx)
"The secret to procrastination is to put things off until the
last possible moment - but no longer" -me

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/