Re: [PATCH 7/7] fuse: support caching negative dentries

[Miklos Szeredi]

> >
> > +void fuse_invalidate_attr(struct inode *inode)
> >  +{
> >  +	get_fuse_inode(inode)->i_time = jiffies - 1;
> >  +}
> >  +
> >  +static void fuse_invalidate_entry_cache(struct dentry *entry)
> >  +{
> >  +	entry->d_time = jiffies - 1;
> >  +}
> >  +
> 
> I'd normally have a little whine about lack of comments here - pity the
> poor programmer who is trying to work out why on earth that code is doing
> that.

Well, I thought it was evident, but it seems not.  I'll add some
comments.

> But fuse is pretty much a comment-free zone anyway.

I think most of FUSE is really-really obvious.  The most complex parts
are in the device handling, which is now quite well commented (thanks
to your earlier whining :).

> Please don't go near any buses.

Don't worry, I usually go by tram.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/