Re: [PATCH 0/4] linux-2.6-block: deactivating pagecache for benchmarks

[Bodo Eggert]

Dirk Henning Gerdes <mail@xxxxxxxxxxxxxx> wrote:

> For doing benchmarks on the I/O-Schedulers, I thought it would be very
> useful to disable the pagecache.
> 
> I didn't want to make it so complicated so I just mark pages as
> not-uptodate, so they have to be read again. Another reason was, that I
> wanted to keep the conditions as near to reality as possible.
> 
> Further I thought it would be useful, if you could turn the pagecache on
> and off without rebooting the system.
> 
> I implemented a proc-fs entry "/proc/benchmark/pagecache" for this.

1) This mail is the only documentation on how to operate your patch.
   How do you suppose your users to find out how to operate the switch?
   (I asume it's really a switch, a toggle would be insane.)

   Since it's very short and only for special purpose, documenting it
   in Kconfig mignt be enough.

2) You're seperating your patches by file, not by function. ungood.

3) Your patches introduce a lot of whitespace.
-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/