Re: [PATCH][mm][Fix] swsusp: fix counting of highmem pages

From: Rafael J. Wysocki
Date: Sat Dec 03 2005 - 19:56:17 EST


Hi,

On Sunday, 4 of December 2005 01:35, Pavel Machek wrote:
> > > > }
> > > > + if (n > 0)
> > > > + n += (n * KMALLOC_SIZE + PAGE_SIZE - 1) / PAGE_SIZE + 1;
> > > > return n;
> > > > }
> > >
> > > Can't you just n += n/50 here? Playing with KMALLOC_SIZE knows way too
> > > much about memory allocation details.
> >
> > I do the "n + n/50" later on, so I can just drop all of the above changes
> > if they are too complicated.
>
> Yes, that would be nice.

OK

In which case I'll have only two changes fixing two different problems,
so I think they should go each in a separate patch. Would that be ok?

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/