Re: swsusp intermittent failures in 2.6.15-rc3-mm1

[Andy Isaacson]

On Fri, Dec 02, 2005 at 11:54:43PM +0100, Rafael J. Wysocki wrote:
> Could you please apply the appended one and see if it fixes the issue?
> It's on top of the previous one.
> 
> It's been compile-tested, but I have no machine with highmem to really
> test it.
> 
> --- linux-2.6.15-rc3-mm1.orig/kernel/power/snapshot.c	2005-12-02 22:02:50.000000000 +0100
> +++ linux-2.6.15-rc3-mm1/kernel/power/snapshot.c	2005-12-02 23:45:13.000000000 +0100
> @@ -37,6 +37,12 @@
>  unsigned int nr_copy_pages;
>  
>  #ifdef CONFIG_HIGHMEM
> +struct highmem_page {
> +	char *data;
> +	struct page *page;
> +	struct highmem_page *next;
> +};
[snip]

Yep, this seems to fix the memory allocation failures at suspend.

Thanks!

(I have another separate issue with (I think) your swsusp changes, but
I'll start a new thread for it rather than extending this one.)

-andy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/