Re: [linux-dvb-maintainer] Re: [PATCH] b2c2: make front-ends selectable and include noob option

From: Patrick Boettcher
Date: Wed Dec 07 2005 - 03:03:45 EST


Hi,

On Wed, 7 Dec 2005, Johannes Stezenbach wrote:
I think b2c2-flexcop-pci uses a 240K dma buffer, whether you
save a few K in demodulator code doesn't mean much.
The saved memory will be similarly unnoticable to the user as
if you would go and scatter #ifdefs all over tuner-simple.c.

But I'm neither the author nor the maintainer of the b2c2-flexcop
driver, you better ask Patrick if he likes it.

There will be at least two new devices in the future, which again will need (at least) two new demod(and maybe tuner)-modules.

Prakash, if it is just the i2c_xfer failed, that could be easily turned into a debug-message, but I rather have these as errors, because they are.

I don't see the need for the ifdef - on the contrary: the number of people asking for which demod they shall load dropped significantly after FE_REFACTORING starting one year ago - now reintroducing that again is not a good idea, IMO.

best regards,
Patrick.

--
Mail: patrick.boettcher@xxxxxxx
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/