Re: swsusp: how much memory to free? [was Re: swsusp performance problems in 2.6.15-rc3-mm1]

From: Pavel Machek
Date: Wed Dec 07 2005 - 07:18:22 EST


Hi!

> > Looks good to me.
> >
> > > Index: linux-2.6.15-rc5-mm1/kernel/power/swsusp.c
> > > ===================================================================
> > > --- linux-2.6.15-rc5-mm1.orig/kernel/power/swsusp.c 2005-12-05 22:07:12.000000000 +0100
> > > +++ linux-2.6.15-rc5-mm1/kernel/power/swsusp.c 2005-12-07 12:40:27.000000000 +0100
> > > @@ -626,6 +626,7 @@
> > >
> > > int swsusp_shrink_memory(void)
> > > {
> > > + unsigned long size;
> > > long tmp;
> >
> > Perhaps both should be long, or both unsigned long?
>
> tmp has to be signed. Both can be long, though.
>
> Should I test it and post for merging?

Yes..
Pavel

--
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/