Re: [PATCH] Fix RCU race in access of nohz_cpu_mask

[Andrew Morton]

Srivatsa Vaddagiri <vatsa@xxxxxxxxxx> wrote:
>
> +		smp_mb();
> +		cpus_andnot(rsp->cpumask, cpu_online_map, nohz_cpu_mask);

Please always include a comment when adding a barrier.  Because it's often
not obvious to the reader what that barrier is actually doing.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/