Re: [PATCH 1/1 2.6.15-rc4-git1] Fixing switch to KD_TEXT, enhancedversion

From: Antonino A. Daplas
Date: Sat Dec 10 2005 - 09:57:33 EST


Knut Petersen wrote:
> Every framebuffer driver relies on the assumption that the
> set_par() function of the driver is called before drawing
> functions and other functions dependent on the hardware
> state are executed.
>
> Whenever you switch from X to a framebuffer console for the
> very first time, there is a chance that a broken X system has
> _not_ set the mode to KD_GRAPHICS, thus the vt and framebuffer
> code executes a screen redraw and several other functions
> before a set_par() is executed. This is believed to be not a
> bug of linux but a bug of X/xdm. At least some X releases
> used by SuSE and Debian show this behaviour.
>
> There was a 2nd case, but that has been fixed by Antonino
> Daplas on 10-dec-2005.
>
> This patch allows drivers to set a flag to inform fbcon_switch()
> that they prefer a set_par() call on every console switch,
> working around the problems caused by the broken X releases.
>
> The flag will be used by the next release of cyblafb and might
> help other drivers that assume a hardware state different to
> the one used by X.
>
> As the default behaviour does not change, this patch should
> be acceptable to everybody.
>
> Signed-off-by: Knut Petersen <Knut_Petersen@xxxxxxxxxxx>

Acked-by: Antonino Daplas <adaplas@xxxxxxx>

> +#define FBINFO_MISC_ALLWAYS_SETPAR 0x40000
^^^^^^^
Please post a follow up patch to fix the spelling.

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/