Re: [PATCH 1/3] m68k: compile fix - hardirq checks were in wrongplace

From: Roman Zippel
Date: Thu Dec 15 2005 - 07:32:42 EST


Hi,

On Thu, 15 Dec 2005, Christoph Hellwig wrote:

> > You separate the definition from the check, now you push the
> > responsibility to get the order right to the header users.
> > Sorry, but I prefer to fix the header dependencies than scatter things
> > which belong together over multiple files.
>
> For 2.6.16 I'll submit a patch to merge asm/irq.h and asm/hardirq.h.

This will likely break m68k header dependencies.

> Until then this is the much better fix because it doesn't require
> pointless include reordering all over the tree.

In this case I would prefer to leave it as is, as it conflicts with m68k
tree and I would prefer to fix the mess only once.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/