Re: [discuss] [patch 1/3] x86_64: Node local pda take 2 -- early cpu_to_node

From: Andi Kleen
Date: Thu Dec 15 2005 - 19:20:28 EST


On Thu, Dec 15, 2005 at 11:01:42AM -0800, Ravikiran G Thirumalai wrote:
> On Thu, Dec 15, 2005 at 10:44:37AM +0100, Andi Kleen wrote:
> > On Wed, Dec 14, 2005 at 06:33:45PM -0800, Ravikiran G Thirumalai wrote:
> > > + * info.
> > > + */
> > > +void __init init_cpu_to_node(void)
> > > +{
> > > + int i;
> > > + for (i = 0; i < NR_CPUS; i++)
> > > + cpu_to_node[i] = apicid_to_node[x86_cpu_to_apicid[i]];
> > > +}
> >
> > I would prefer it if you moved that to numa.c and run always
> > (even for the k8topology case). Otherwise k8topology will behave
> > differently whether CONFIG_ACPI_NUMA is set or not, and I don't like
> > that.
>
> Sure! I moved it to srat.c based on your suggestion to my earlier post.
> I will move this to numa.c.

Sorry for changing my mind on this. I hope you can bear with me.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/