Re: [RFC] Updates to sysfs_create_subdir()

[Patrick Mochel]

On Mon, 5 Dec 2005, Maneesh Soni wrote:

>
> (cc-ing Al for his views)
>
> On Wed, Nov 30, 2005 at 09:05:41AM -0800, Patrick Mochel wrote:
> >
> > On Mon, 28 Nov 2005, Greg KH wrote:
> >
> > > On Wed, Nov 23, 2005 at 01:56:29PM -0800, Patrick Mochel wrote:
> > > >
> > > > The patch below addresses this issue by parsing the subdirectory name and
> > > > creating any parent directories delineated by a '/'.
> > >
>
> well, creating directory hierarchy for attributes in one shot could be
> useful in some cases, but is it worth putting more fuel to race conditions
> in sysfs? I am afraid that there could be extra efforts also needed for
> userspace to manage the namespace collisions in sysfs.

Yeah, after more thought, it doesn't seem necessary, nor worth it to spend
the time ironing out all of the details.

> Nested attributes will not be straight forward. With this scheme do all
> attributes in the attrbiute tree belong to same kobject?

Yes, they would all belong to the same kobject, which means they would all
have to go away when the kobject did, which could get hairy, especially
when kobjects are added/removed in rapid succession.

I think the best approach is to scrap this idea and to leverage other
existing infrastructure better..

Thanks for the commentary, and sorry about the delay in responding,


	Patrick

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/