Re: [RFC][PATCH 1/6] RTC subsystem, class

From: Alessandro Zummo
Date: Wed Dec 21 2005 - 04:48:38 EST


On Tue, 20 Dec 2005 21:01:39 -0500
Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx> wrote:


> > +       if (ops->read_time) {
> > +               memset(tm, 0, sizeof(struct rtc_time));
> >
>
> What guarantees that ops is not NULL here? Userspace can keep the
> attribute (file) open and issue read after class_device was unregistered
> and devdata set to NULL.

Right. For /proc and /dev there's a try_module_get(ops->owner) in place.

Should I add it to every rtc_sysfs_show_xxx or there's
a better way to do it?

--

Best regards,

Alessandro Zummo,
Tower Technologies - Turin, Italy

http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/