Re: [PATCH 2.6-git] SPI: add set_clock() to bitbang

[Vitaly Wool]

David Brownell wrote:

> On Thursday 22 December 2005 7:04 am, Vitaly Wool wrote:
>  
>
> > Hi David,
> >
> > inlined is the small patch that adds set_clock function to the spi_bitbang structure.
> >    
>
> This is actually not needed.  Clocks are set through the setup() method
> in the spi_master, and controller drivers are (courtesy of the library
> approach) free to provide their own.  Drivers for word-at-a-time hardware
> would still need to call spi_bitbang_setup() in their own setup() code,
> to set up the per-device controller_state, and spi_bitbang_cleanup() in
> their own cleanup() code, to deallocate it.
>  
Where is it supposed to call setup? I guess it's anyway gonna be 
per-transfer, right?
Or am I missing something?

Vitaly
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/