Re: [2.6 patch] i386: always use 4k stacks

From: Pavel Machek
Date: Fri Dec 23 2005 - 18:07:52 EST


On Pá 23-12-05 11:12:38, Bodo Eggert wrote:
> Horst von Brand <vonbrand@xxxxxxxxxxxx> wrote:
>
> > "With some drawbacks" is the point: It has been determined that the
> > drawbacks are heavy enough that the 8KiB stack option should go.
>
> Determined by voodoo and wild guessing.
>
> Let's detect the need for 4K stacks: (I hope I found the correct place)
>
> (Maybe the printk should be completely ifdefed, but I'm not sure)
>
>
> Signed-off-by: Bodo Eggert <7eggert@xxxxxx>
>
> --- 2.6.14/kernel/fork.c.ori 2005-12-21 19:06:24.000000000 +0100
> +++ 2.6.14/kernel/fork.c 2005-12-21 19:15:23.000000000 +0100
> @@ -168,4 +168,9 @@ static struct task_struct *dup_task_stru
> if (!ti) {
> free_task_struct(tsk);
> + printk(KERN_WARNING, "Can't allocate new task structure"
> +#ifndef CONFIG_4KSTACKS
> + ". Maybe you could benefit from 4K stacks.\n"
> +#endif
> + "\n");
> return NULL;
> }

Two newlines in case of 4Kstacks...

Pavel

--
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/