Re: [WTF?] sys_tas() on m32r

[Jesper Juhl]

On 12/23/05, Lee Revell <rlrevell@xxxxxxxxxxx> wrote:
> On Fri, 2005-12-23 at 05:55 -0800, Andrew Morton wrote:
> > Al Viro <viro@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > asmlinkage int sys_tas(int *addr)
> > > {
> > >         int oldval;
> > >         unsigned long flags;
> > >
> > >         if (!access_ok(VERIFY_WRITE, addr, sizeof (int)))
> > >                 return -EFAULT;
> > >         local_irq_save(flags);
> > >         oldval = *addr;
> > >         if (!oldval)
> > >                 *addr = 1;
> > >         local_irq_restore(flags);
> > >         return oldval;
> > > }
> > > in arch/m32r/kernel/sys_m32r.c.  Trivial oops *AND* ability to trigger
> > > IO with interrupts disabled.
> >
> > Yeah.  I pointed this out to Takata in October last year and then promptly
> > forgot about it.  It's rather amazing that this code (which appears to be in
> > live use in linuxthreads) hasn't generated oopses.
>
> No one uses LinuxThreads anymore?
>
Slackware still uses LinuxThreads.
Latest release and -current include both NPTL & LinuxThreads, and use
NPTL if the running kernel is >2.6.4 or LinuxThreads if <=2.6.4 or
when running a 2.4 kernel (2.4 is still the default kernel in
Slackware although 2.6.x is also fully supported).

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/